perf(build): isolate CLI Core capability closure - #2014
Merged
Conversation
limityan
marked this pull request as ready for review
August 4, 2026 00:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-core/product-fullselection with reviewed owner-feature closures.agent-runtime,external-sources,plugin-runtime, anddebug-log, while retainingproduct-fullas the full compatibility union.Architecture and compatibility
agent-runtime,canvas-runtime,external-sources,plugin-runtime, andssh-remote.agent-runtime,canvas-runtime,external-sources, andssh-remote.agent-runtime; third-party Hook discovery/import remains inexternal-sources.PublishAppearancepath remains available throughagent-runtime, including itssemverdependency.Dependency graph
Measured against
GCWing/BitFun@213b32b8, usingcargo tree --locked -e normal,buildand unique package name/version identities:product-fullCLI and ACP each remove only
http-range-header v0.4.2; theproduct-fullpackage set is unchanged. This PR does not claim a stable cold/hot wall-clock improvement—the primary result is preventing future full-product capability growth from automatically entering smaller product surfaces.Validation
node --test scripts/check-core-boundaries.test.mjs— 67/67 passednode scripts/check-core-boundaries.mjscargo check --locked -p bitfun-core --no-default-features --features agent-runtimecargo check --locked -p bitfun-core --no-default-features --features product-fullcargo check --locked -p bitfun-clicargo check --locked -p bitfun-acpcargo test --locked -p bitfun-product-capabilities --test product_capabilities— 23/23 passedcargo test --locked -p bitfun-cli --bin bitfun product_assembly— 3/3 passedcargo test --locked -p bitfun-acp --lib— 112/112 passedcargo test --locked -p bitfun-core --no-default-features --features agent-runtime,canvas-runtime,external-sources,ssh-remote --lib product_tool_runtime_can_consume_acp_product_assembly_plan— 1/1 passedgit diff gcwing/main...HEAD --checkAdversarial review
Three independent review rounds covered architecture ownership, production runtime materialization, Cargo feature resolution, and delivery scope. Findings around ACP Canvas materialization, target/build/proc-macro closure semantics, indirect ACP expansion, non-default root features, and owner-definition self-authorization were fixed with focused regression coverage. Final architecture, runtime, and delivery reviews reported no remaining P0-P3 findings.